Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changefeed(ticdc): add namespace info into ChangeFeedID #5300

Merged
merged 14 commits into from
May 5, 2022
Merged

changefeed(ticdc): add namespace info into ChangeFeedID #5300

merged 14 commits into from
May 5, 2022

Conversation

sdojjy
Copy link
Member

@sdojjy sdojjy commented Apr 27, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #5301

What is changed and how it works?

make ChangefeedID to an struct

type ChangeFeedID struct {
	Namespace string
	ID        string
}

after this PR, all changefeed has an default namespace value, "default"

func DefaultNamespaceChangeFeedID(id string) ChangeFeedID {
	return ChangeFeedID{
		Namespace: DefaultNamespace,
		ID:        id,
	}
}

namesapce and ID pair is unique in one ticdc cluster

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update key monitor metrics in both TiCDC document and official document

Release note 

Please add a release note.
 `None`.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 27, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • asddongmen

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 27, 2022
@sdojjy
Merge remote-tracking branch 'upstream/master' into add-namespace-inf…
065eeca 
…o-into-changefeed

# Conflicts:
#	pkg/cmd/cli/cli_changefeed_helper.go
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 27, 2022
@sdojjy sdojjy mentioned this pull request Apr 27, 2022
Closed
3 tasks
asddongmen
asddongmen reviewed Apr 28, 2022
View reviewed changes
cdc/model/changefeed.go Outdated Show resolved Hide resolved
@sdojjy
Copy link
Member Author

sdojjy commented Apr 29, 2022

/run-integration-tests

@sdojjy
Copy link
Member Author

sdojjy commented Apr 29, 2022

/run-verify-test

@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2022 •
edited
Loading

Codecov Report

Merging #5300 (9971098) into master (687e248) will decrease coverage by 0.0194%.
The diff coverage is 55.9465%.

Flag Coverage Δ
cdc 60.7848% <55.9465%> (+0.1862%) ⬆️
dm 52.3891% <ø> (-0.0805%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #5300        +/-   ##
================================================
- Coverage   56.1240%   56.1045%   -0.0195%     
================================================
  Files           522        527         +5     
  Lines         65325      69039      +3714     
================================================
+ Hits          36663      38734      +2071     
- Misses        25094      26576      +1482     
- Partials       3568       3729       +161

@sdojjy
Copy link
Member Author

sdojjy commented Apr 29, 2022

/run-kafka-integration-test

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 1, 2022
@sdojjy
Merge branch 'master' into add-namespace-info-into-changefeed
e81fea4 
# Conflicts:
#	cdc/kv/client.go
#	cdc/kv/client_bench_test.go
#	cdc/kv/client_test.go
#	cdc/kv/region_worker.go
#	cdc/processor/pipeline/puller.go
#	cdc/processor/processor.go
#	cdc/puller/puller_test.go
#	cdc/sink/mq/mq.go
#	cdc/sink/mysql/mysql.go
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 5, 2022
@sdojjy
Copy link
Member Author

sdojjy commented May 5, 2022

/run-all-tests

asddongmen
asddongmen reviewed May 5, 2022
View reviewed changes
cdc/contextutil/ctx.go Outdated Show resolved Hide resolved
asddongmen
asddongmen reviewed May 5, 2022
View reviewed changes
cdc/contextutil/ctx.go Outdated Show resolved Hide resolved
@asddongmen
Copy link
Contributor

/rest LGTM

sdojjy and others added 3 commits May 5, 2022 15:11
@sdojjy @asddongmen
Update cdc/contextutil/ctx.go
3423616 
Co-authored-by: dongmen <20351731+asddongmen@users.noreply.github.com>
@sdojjy @asddongmen
Update cdc/contextutil/ctx.go
577a847 
Co-authored-by: dongmen <20351731+asddongmen@users.noreply.github.com>
@sdojjy
Merge branch 'master' into add-namespace-info-into-changefeed
a7a8bdc
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 5, 2022
@asddongmen
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@asddongmen: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sdojjy
Copy link
Member Author

sdojjy commented May 5, 2022

/run-verify-test

@asddongmen asddongmen added the require-LGT1 Indicates that the PR requires an LGTM. label May 5, 2022
@asddongmen
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a7a8bdc

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 5, 2022
@sdojjy
Copy link
Member Author

sdojjy commented May 5, 2022

/run-integration-tests

@ti-chi-bot ti-chi-bot merged commit 196de8b into pingcap:master May 5, 2022
@sdojjy sdojjy deleted the add-namespace-info-into-changefeed branch May 5, 2022 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asddongmen asddongmen asddongmen approved these changes

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. require-LGT1 Indicates that the PR requires an LGTM. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sdojjy @ti-chi-bot @codecov-commenter @asddongmen